[dm-devel] [PATCH 2/3] dm: Add support to poll for dm events

[Andy Grover]

Please see below for some bugs I spotted.

The surest way to find bugs is to post patches to a public list :-/

On 01/09/2017 10:20 AM, Andy Grover wrote:
> +int dm_release(struct inode *inode, struct file *filp)

> +	if (priv->md) {

should be "if (priv && priv->md)"

> +static unsigned int dm_poll(struct file *filp, poll_table *wait)

> +	if (!priv->md)

should be "if (!priv || !priv->md)"

Regards -- Andy