[dm-devel] [PATCH] dm bufio: Fix error code in dm_bufio_write_dirty_buffers()

Christoph Hellwig hch at lst.de
Wed Jul 12 07:30:07 UTC 2017


On Wed, Jul 12, 2017 at 10:26:34AM +0300, Dan Carpenter wrote:
> We should be returning normal negative error codes here.  The "a"
> variables comes from &c->async_write_error which is a blk_status_t
> converted to a regular error code.
> 
> In the current code, the blk_status_t gets propogated back to
> pool_create() and eventually results in an Oops.

And sparse correctly warns about this, so no idea how this slipped in..

> 
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the dm-devel mailing list