[dm-devel] [PATCH] multipath-tools: don't discard uevent for NVMe-Fabrics device

Martin Wilck mwilck at suse.com
Thu Jul 13 10:04:56 UTC 2017


On Thu, 2017-07-13 at 15:47 +0800, Guan Junxiong wrote:
> The devpath of uevent of NVMe-Fabrics device is like this
> "../devices/virtual/nvme-fabrics/ctl/nvme0/nvme0n1" which
> doesn't contains the "/block/" string. So when new uvents
> of such nvme devices arise, the multipathd daemon still ignores
> them, which results the DM-multipath doesn't update the table.
> This patch fixes this by introducing a new helper to filter
> "/block/" and "nvme-fabrics/ctl".
> 
> Signed-off-by: Junxiong Guan <guanjunxiong at huawei.com>

The analysis is correct, but NAK nonetheless for the patch. The whole
uevent_can_discard_by_devpath() approach is broken. I'll send a patch
dropping that function entirely later today.

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)




More information about the dm-devel mailing list