[dm-devel] dm-integrity: fix inefficient allocation of stack space

[Mikulas Patocka]

On Wed, 19 Jul 2017, John Stoffel wrote:

> I'd like to argue that you should never use BUG_ON at all, esp since
> if you have integrity running on just one critical device, but have
> other devices that work just fine, bringing down the entire system
> because you don't think things are ok is terrible.
> 
> We should rip out ALL the BUG_ONs in the dm-integrity and just do
> proper error handling instead.  For testing, sure, use them on your
> code.  But please, not for general use!
> 
> John

Linus sometimes argued against BUG_ON and people are repeating it after 
him like sheep.

If a programmer made a bug in his code, he should fix that bug, not write 
additional recovery code for the bug.

Mikulas