[dm-devel] block: missing break in process_queued_bios()
Mike Snitzer
snitzer at redhat.com
Wed Jun 14 13:18:13 UTC 2017
On Wed, Jun 14 2017 at 5:04am -0400,
Dan Carpenter <dan.carpenter at oracle.com> wrote:
> This used to be a fall through case, but we shifted code around and I
> think we want a break here now.
>
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index a7d2e0840cc5..0e8ab5bb3575 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)
> case DM_MAPIO_KILL:
> bio->bi_status = BLK_STS_IOERR;
> bio_endio(bio);
> + break;
> case DM_MAPIO_REQUEUE:
> bio->bi_status = BLK_STS_DM_REQUEUE;
> bio_endio(bio);
Annoyed with myself for missing this during my review...
The subject should be:
"dm mpath: add missing break in process_queued_bios()"
Also, this should go through Jens and I'll rebase my linux-dm branches
accordingly. Jens, please pick this up.
Acked-by: Mike Snitzer <snitzer at redhat.com>
Thanks!
More information about the dm-devel
mailing list