[dm-devel] [PATCH v3 01/11] libmultipath: load_config: skip setting unnecessary defaults
Hannes Reinecke
hare at suse.de
Thu Jun 22 06:01:38 UTC 2017
On 06/21/2017 05:06 PM, Martin Wilck wrote:
> We have the logic for setting defaults for paths and maps
> in propsel.c. By pre-setting conf values with defaults in
> load_config(), we generate irritating log messages like
> 'features = "0" (setting: multipath.conf defaults/devices section)'
> if multipath.conf doesn't contain a features setting at all.
>
> For some config settings, we need to use declare_def_snprint_defint()
> now to make sure "multipathd show config" prints all defaults correctly.
> To avoid confusion, we don't do this for "max_sectors", because
> multipathd leaves this untouched by default.
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> Acked-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
> libmultipath/config.c | 16 ----------------
> libmultipath/dict.c | 11 +++++++----
> libmultipath/propsel.c | 6 ++++++
> 3 files changed, 13 insertions(+), 20 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare at suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
More information about the dm-devel
mailing list