[dm-devel] [PATCH v3 03/11] libmultipath: clarify option conflicts for "features"

[Hannes Reinecke]

On 06/21/2017 05:06 PM, Martin Wilck wrote:
> The "features" option in multipath.conf can possibly conflict
> with "no_path_retry" and "retain_attached_hw_handler".
> 
> Currently, "no_path_retry" takes precedence, unless it is set to
> "fail", in which case it's overridden by "queue_if_no_path".
> This is odd, either "features" or "no_path_retry" should take
> precedence.
> No precedence rules are defined for "retain_attached_hw_handler".
> 
> Make this behavior more consistent by always giving precedence
> to the explicit config file options, and improve logging.
> 
> Put this logic into a separate function, which can be used
> from other places in the code.
> 
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  libmultipath/configure.c |  6 ++---
>  libmultipath/propsel.c   | 68 +++++++++++++++++++++++++++++++++++++-----------
>  libmultipath/propsel.h   |  3 +++
>  3 files changed, 59 insertions(+), 18 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)