[dm-devel] [PATCH RESEND] dm-raid: Do not call BUG() in __rdev_sectors()

[Johannes Thumshirn]

On Thu, Jun 29, 2017 at 04:09:38PM +0200, Heinz Mauelshagen wrote:
> 
> Hi Hannes,
> 
> thanks for your patch.
> 
> BUG() is intentional there to catch what I've already fixed with patch
> 
> "[dm-devel] [PATCH] dm raid: fix oops on upgrading to extended superblock
> format"
> 
> on 06/23/2017.
> 
> IOW: returning 0 is never right and would hide bugs like that one fixed.

OTOH panicing systems to catch errors which could've been mitigted is
never right as well. Not a single time. Never. BUG() and BUG_ON() are not
for error handling.

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850