[dm-devel] [PATCH] multipath-tools: arrange compilation options for binaries

Christophe Varoqui christophe.varoqui at opensvc.com
Thu Mar 23 09:09:42 UTC 2017


And reverted:

>From http://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking
:

If object or library AA needs a symbol from library BB, then AA should come
*before* library BB in the command-line invocation of the linker.



On Thu, Mar 23, 2017 at 9:34 AM, Christophe Varoqui <
christophe.varoqui at opensvc.com> wrote:

> Merged,
> Thanks.
>
> On Fri, Mar 17, 2017 at 11:40 PM, Xose Vazquez Perez <
> xose.vazquez at gmail.com> wrote:
>
>> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
>> Cc: device-mapper development <dm-devel at redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
>> ---
>>  kpartx/Makefile       | 2 +-
>>  mpathpersist/Makefile | 2 +-
>>  multipath/Makefile    | 2 +-
>>  multipathd/Makefile   | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kpartx/Makefile b/kpartx/Makefile
>> index 9441a2b..2e81284 100644
>> --- a/kpartx/Makefile
>> +++ b/kpartx/Makefile
>> @@ -19,7 +19,7 @@ EXEC = kpartx
>>  all: $(EXEC)
>>
>>  $(EXEC): $(OBJS)
>> -       $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)
>> +       $(CC) $(CFLAGS) $(LDFLAGS) $(LIBDEPS) $(OBJS) -o $(EXEC)
>>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>>
>>  install: $(EXEC) $(EXEC).8
>> diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile
>> index 47043bb..27e921e 100644
>> --- a/mpathpersist/Makefile
>> +++ b/mpathpersist/Makefile
>> @@ -12,7 +12,7 @@ OBJS = main.o
>>  all: $(EXEC)
>>
>>  $(EXEC): $(OBJS)
>> -       $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS) $(LIBDEPS)
>> +       $(CC) $(CFLAGS) $(LDFLAGS) $(LIBDEPS) $(OBJS) -o $(EXEC)
>>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>>
>>  install:
>> diff --git a/multipath/Makefile b/multipath/Makefile
>> index cad34bf..421490c 100644
>> --- a/multipath/Makefile
>> +++ b/multipath/Makefile
>> @@ -15,7 +15,7 @@ OBJS = main.o
>>  all: $(EXEC)
>>
>>  $(EXEC): $(OBJS)
>> -       $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)
>> +       $(CC) $(CFLAGS) $(LDFLAGS) $(LIBDEPS) $(OBJS) -o $(EXEC)
>>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>>         $(GZIP) $(EXEC).conf.5 > $(EXEC).conf.5.gz
>>
>> diff --git a/multipathd/Makefile b/multipathd/Makefile
>> index d57f6d5..a3fad61 100644
>> --- a/multipathd/Makefile
>> +++ b/multipathd/Makefile
>> @@ -29,7 +29,7 @@ EXEC = multipathd
>>  all : $(EXEC)
>>
>>  $(EXEC): $(OBJS)
>> -       $(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC) $(LIBDEPS)
>> +       $(CC) $(CFLAGS) $(LDFLAGS) $(LIBDEPS) $(OBJS) -o $(EXEC)
>>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>>
>>  install:
>> --
>> 2.12.0
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20170323/98d7e32b/attachment.htm>


More information about the dm-devel mailing list