[dm-devel] [PATCH] multipath-tools: arrange compilation options for binaries

[Christophe Varoqui]

Yes indeed, the build really failed on my box.

Toolchain versions :
* gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.2)
* GNU ld (GNU Binutils for Ubuntu) 2.26.1

make log :

cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
-Werror=implicit-function-declaration -Werror=format-security
-Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
-fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
-I../libmpathcmd  -lpthread -ldevmapper -ldl -L../libmultipath -lmultipath
-ludev -L../libmpathcmd -lmpathcmd main.o -o multipath
main.o: In function `get_dm_mpvec':
/home/cvaroqui/multipath-tools/multipath/main.c:209: undefined reference to
`dm_get_maps'
/home/cvaroqui/multipath-tools/multipath/main.c:228: undefined reference to
`dm_get_map'
/home/cvaroqui/multipath-tools/multipath/main.c:229: undefined reference to
`dlog'
/home/cvaroqui/multipath-tools/multipath/main.c:230: undefined reference to
`dm_get_status'
/home/cvaroqui/multipath-tools/multipath/main.c:231: undefined reference to
`dlog'
/home/cvaroqui/multipath-tools/multipath/main.c:233: undefined reference to
`disassemble_map'
...
<snip: many more reference errors>
...
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'multipath' failed
make[1]: *** [multipath] Error 1
make[1]: Leaving directory '/home/cvaroqui/multipath-tools/multipath'
Makefile:46: recipe for target 'recurse' failed
make: *** [recurse] Error 2


On Thu, Mar 23, 2017 at 3:02 PM, Xose Vazquez Perez <xose.vazquez at gmail.com>
wrote:

> On 03/23/2017 10:09 AM, Christophe Varoqui wrote:
>
> > And reverted:
> > hh
> > From http://eli.thegreenplace.net/2013/07/09/library-order-in-
> static-linking:
> >
> >     If object or library AA needs a symbol from library BB, then AA
> should
> >     come /before/ library BB in the command-line invocation of the
> linker.
>
> Did you get a toolchain error?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20170323/a98d34cd/attachment.htm>