[dm-devel] [PATCH 1/2] multipath: Merge the DELL MD3xxx device configs

[Xose Vazquez Perez]

On 04/13/2017 12:15 AM, Benjamin Marzinski wrote:

> All of the Dell MD3xxx configs are identical, so we can't just use
> one config for them.

If you do that to simplify the config file or minimize the number of
RDAC entries. More of them, from (NETAPP|LSI|ENGENIO) IBM SGI STK SUN,
can be consolidated: grep -B7 -A2 "PRIO_RDAC" libmultipath/hwtable.c


BTW, I did send time ago a kernel patch related to RDAC arrays and
it's still waiting for ACK: https://marc.info/?l=linux-scsi&m=147585935707470

> Cc: Xose Vazquez Perez <xose.vazquez at gmail.com>
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
>  libmultipath/hwtable.c | 26 +-------------------------
>  1 file changed, 1 insertion(+), 25 deletions(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index c944015..54309ef 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -227,31 +227,7 @@ static struct hwentry default_hw[] = {
>  		/* MD Series */
>  	{
>  		.vendor        = "DELL",
> -		.product       = "MD3000",
> -		.bl_product    = "Universal Xport",
> -		.pgpolicy      = GROUP_BY_PRIO,
> -		.checker_name  = RDAC,
> -		.features      = "2 pg_init_retries 50",
> -		.hwhandler     = "1 rdac",
> -		.prio_name     = PRIO_RDAC,
> -		.pgfailback    = -FAILBACK_IMMEDIATE,
> -		.no_path_retry = 30,
> -	},
> -	{
> -		.vendor        = "DELL",
> -		.product       = "(MD32xx|MD36xx)",
> -		.bl_product    = "Universal Xport",
> -		.pgpolicy      = GROUP_BY_PRIO,
> -		.checker_name  = RDAC,
> -		.features      = "2 pg_init_retries 50",
> -		.hwhandler     = "1 rdac",
> -		.prio_name     = PRIO_RDAC,
> -		.pgfailback    = -FAILBACK_IMMEDIATE,
> -		.no_path_retry = 30,
> -	},
> -	{
> -		.vendor        = "DELL",
> -		.product       = "(MD34xx|MD38xx)",
> +		.product       = "^MD3",
>  		.bl_product    = "Universal Xport",
>  		.pgpolicy      = GROUP_BY_PRIO,
>  		.checker_name  = RDAC,
>