[dm-devel] [PATCH 00/10] fixes for kpartx -d

Hannes Reinecke hare at suse.de
Mon May 8 06:33:34 UTC 2017


On 05/06/2017 12:30 AM, Martin Wilck wrote:
> On Fri, 2017-05-05 at 23:18 +0100, Alasdair G Kergon wrote:
>> On Sat, May 06, 2017 at 12:05:49AM +0200, Martin Wilck wrote:
>>>   3) kpartx should only delete "partitions", which are single-
>>> target
>>>      linear mappings into a block device. Other maps should not be
>>> touched.
>>
>> The prefix on the dm device's uuid should guarantee this: all devices
>> kpartx creates should have the same initial characters (a
>> not-quite-standard form "part" IIRC instead of "KPARTX-") and any
>> devices without those initial characters must be ignored.
> 
> This works only for partitions on DM devices, not e.g. for loop
> devices. These devices obviously have no DM UUID; and thus kpartx also
> doesn't set an UUID for the partition devices it creates.
> That's the main point of this series.
> 
I beg to differ.

The main point is to _set_ an UUID for all kpartx-generated devices.
But to make matters consistent I'm siding with Alasdair here, namely
that any kpartx-generated UUID should be starting with 'part-'.
So I'm fine with adding a UUID, but this UUID _must_ start with 'part-'.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)




More information about the dm-devel mailing list