[dm-devel] [PATCH v2 04/11] crypto: move drbg to generic async completion

Stephan Müller smueller at chronox.de
Mon May 29 09:04:01 UTC 2017


Am Montag, 29. Mai 2017, 10:22:51 CEST schrieb Gilad Ben-Yossef:

Hi Gilad,

> DRBG is starting an async. crypto op and waiting for it complete.
> Move it over to generic code doing the same.
> 
> The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating
> crypto request memory allocation may use GFP_KERNEL which should
> be perfectly fine as the code is obviously sleeping for the
> completion of the request any way.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad at benyossef.com>

Acked-by: Stephan Müller <smueller at chronox.de>

However, please note that there is a patch "crypto:drbg- Fixes panic in 
wait_for_completion call." which adds another init_completion. I guess that 
needs conversion to crypto_init_wait as well, once this patch set is accepted.


Ciao
Stephan




More information about the dm-devel mailing list