[dm-devel] [PATCH 4/4] hwtable: set 'none' as default checker for NVMe

Guan Junxiong guanjunxiong at huawei.com
Fri Sep 15 10:00:32 UTC 2017


Looks good.

Reviewed-by: Guan Junxiong <guanjunxiong at huawei.com>


On 2017/9/15 14:30, Hannes Reinecke wrote:
> We shouldn't be using the directio checker for NVMe, as this might
> cause spurious path failures under high load.
> As the 'state' attribute provides reliable information about the link
> status it's sufficient to just check this and don't call any
> path checkers.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
>  libmultipath/hwtable.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 9e14ec1..9ac09ff 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1113,7 +1113,7 @@ static struct hwentry default_hw[] = {
>  		.vendor        = "NVME",
>  		.product       = ".*",
>  		.uid_attribute = "ID_WWN",
> -		.checker_name  = DIRECTIO,
> +		.checker_name  = NONE,
>  		.retain_hwhandler = RETAIN_HWHANDLER_OFF,
>  	},
>  	/*
> 




More information about the dm-devel mailing list