[dm-devel] [PATCH] libmultipath: sanitize fd handling

[Martin Wilck]

On Wed, 2017-09-20 at 13:32 +0200, Martin Wilck wrote:
> On Fri, 2017-09-15 at 08:15 +0200, Hannes Reinecke wrote:
> > 
> > Signed-off-by: Hannes Reinecke <hare at suse.com>
> > ---
> >  libmultipath/checkers.c | 4 ++--
> >  libmultipath/print.c    | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> 
> There's one more wrong fd reference in
> libmultipath/checkers/cciss_tur.c:76. And a nitpick: The comment in
> checkers.h:14 should be fixed as well.
> 
> Apart from that: nice (although not strictly necessary, as multipathd
> currently runs with fd 0 connected to /dev/null under normal
> conditions).
> 

I overlooked the memset usage in my review. Hannes himself brought that
to my attention. Will send fixup patch in a minute.

Martin 

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)