[dm-devel] limits->max_sectors is getting set to 0, why/where? [was: Re: dm: kernel oops by divide error on v4.16+]

Jens Axboe axboe at kernel.dk
Tue Apr 10 00:31:22 UTC 2018


On 4/9/18 5:54 PM, Linus Torvalds wrote:
> On Mon, Apr 9, 2018 at 3:32 PM, Jens Axboe <axboe at kernel.dk> wrote:
>>
>> The resulting min/max and friends would have been trivial to test, but
>> clearly they weren't.
> 
> Well, the min/max macros themselves actually were tested in user space by me.
> 
> It was the interaction with the unrelated "min_not_zero()" that wasn't ;)
> 
> It's easy in hind-sight to say "that's not at all unrelated", but
> within the context of doing min/max, it was.

I guess we should just be thankful that it didn't cause bigger issues
than an oops.

-- 
Jens Axboe




More information about the dm-devel mailing list