[dm-devel] [PATCH 1/2] libmultipath: hwhandler auto-detection for ALUA
Benjamin Marzinski
bmarzins at redhat.com
Thu Apr 12 19:49:48 UTC 2018
On Thu, Apr 12, 2018 at 05:43:39PM +0200, Martin Wilck wrote:
> Hi Ben,
>
> I'm unsure what to do. Do you still reject my patch? Or have you been
> convinced by Hannes and my arguments?
> Or are you requesting changes? If yes, what?
I still feel that it's better to make the default config const for
devices that may or may not be ALUA, and let detect_alua figure it out,
rather than allowing multipathd to override a specifically requested
ALUA hardware handler. This is especially true if
get_target_port_group_support() and get_target_port_group succeed, but
get_asymmetric_access_state() fails in detect_alua(). But I don't think
that transient alua errors like this are very likely during multpath
creation, so I not going to reject the patch.
Reviewed-by: Benjmain Marzinski <bmarzins at redhat.com>
>
> Regards,
> Martin
>
> --
> Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
More information about the dm-devel
mailing list