[dm-devel] [PATCH 14/32] kpartx: fix bad dm_devn return
Benjamin Marzinski
bmarzins at redhat.com
Wed Aug 1 20:57:00 UTC 2018
dm_devn shouldn't be returning success if you can't create a dm task to
find the device info. Found by coverity.
Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
---
kpartx/devmapper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kpartx/devmapper.c b/kpartx/devmapper.c
index cd33449..8db1eb5 100644
--- a/kpartx/devmapper.c
+++ b/kpartx/devmapper.c
@@ -365,7 +365,7 @@ dm_devn (const char * mapname, int *major, int *minor)
struct dm_info info;
if (!(dmt = dm_task_create(DM_DEVICE_INFO)))
- return 0;
+ return 1;
if (!dm_task_set_name(dmt, mapname))
goto out;
--
2.7.4
More information about the dm-devel
mailing list