[dm-devel] LVM snapshot broke between 4.14 and 4.16

Linus Torvalds torvalds at linux-foundation.org
Fri Aug 3 19:22:09 UTC 2018

On Fri, Aug 3, 2018 at 12:06 PM Mike Snitzer <snitzer at redhat.com> wrote:
> How does that pass for a fix to this issue?
> That'll unilaterally mark all dm device's readonly.

Well, if it wasn't honored before anyway, then...

But yes, a much more targeted patch would be preferred.

And in fact, maybe the right thing to do is to not revert the original
commit entirely, but instead just weaken it a lot. Turn the "you did a
write request on a RO disk" into a WARN_ON_ONCE() instead of a hard

Something like the attached patch.

WGH, do you build your own kernels? Does this attached (untested)
patch make things work for you? It should give a big warning, but let
the old behavior through..

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 664 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20180803/36675b19/attachment.bin>

More information about the dm-devel mailing list