[dm-devel] [PATCH 09/19] libmultipath: make close_fd() a common helper
Martin Wilck
mwilck at suse.com
Tue Dec 18 23:19:21 UTC 2018
move close_fd() into util.c.
Signed-off-by: Martin Wilck <mwilck at suse.com>
---
libmultipath/sysfs.c | 5 -----
libmultipath/util.c | 5 +++++
libmultipath/util.h | 2 ++
multipath/main.c | 4 ----
4 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/libmultipath/sysfs.c b/libmultipath/sysfs.c
index 558c8d6a..65904d7b 100644
--- a/libmultipath/sysfs.c
+++ b/libmultipath/sysfs.c
@@ -295,11 +295,6 @@ static int select_dm_devs(const struct dirent *di)
return fnmatch("dm-*", di->d_name, FNM_FILE_NAME) == 0;
}
-static void close_fd(void *arg)
-{
- close((long)arg);
-}
-
bool sysfs_is_multipathed(const struct path *pp)
{
char pathbuf[PATH_MAX];
diff --git a/libmultipath/util.c b/libmultipath/util.c
index 28eb7577..944c632e 100644
--- a/libmultipath/util.c
+++ b/libmultipath/util.c
@@ -506,3 +506,8 @@ void free_scandir_result(struct scandir_result *res)
FREE(res->di[i]);
FREE(res->di);
}
+
+void close_fd(void *arg)
+{
+ close((long)arg);
+}
diff --git a/libmultipath/util.h b/libmultipath/util.h
index dea3fa04..1e0d832c 100644
--- a/libmultipath/util.h
+++ b/libmultipath/util.h
@@ -35,6 +35,8 @@ void set_max_fds(int max_fds);
#define pthread_cleanup_push_cast(f, arg) \
pthread_cleanup_push(((void (*)(void *))&f), (arg))
+void close_fd(void *arg);
+
struct scandir_result {
struct dirent **di;
int n;
diff --git a/multipath/main.c b/multipath/main.c
index f40c179b..a25e1b4f 100644
--- a/multipath/main.c
+++ b/multipath/main.c
@@ -388,10 +388,6 @@ enum {
};
static const char shm_find_mp_dir[] = MULTIPATH_SHM_BASE "find_multipaths";
-static void close_fd(void *arg)
-{
- close((long)arg);
-}
/**
* find_multipaths_check_timeout(wwid, tmo)
--
2.19.2
More information about the dm-devel
mailing list