[dm-devel] [PATCH 1/3] multipath.rules: handle NVME devices

[Benjamin Marzinski]

On Fri, Jan 19, 2018 at 01:19:42AM +0100, Martin Wilck wrote:
> Note: ID_WWN is set in 60-persistent-storage.rules in current systemd.
> That won't work well together with us installing multipath.rules as
> 56-multipath.rules -  multipath -u won't see ID_WWN.
> 
> However, we have strong reasons to run before blkid is invoked.
> ID_WWN determination for NVMe should be moved to an earlier udev rule.
> See systemd pull request #7594 on github.
> 

ACK for all three.
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  multipath/multipath.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/multipath/multipath.rules b/multipath/multipath.rules
> index bc1a8529638f..6f8ee2be0a58 100644
> --- a/multipath/multipath.rules
> +++ b/multipath/multipath.rules
> @@ -1,7 +1,7 @@
>  # Set DM_MULTIPATH_DEVICE_PATH if the device should be handled by multipath
>  SUBSYSTEM!="block", GOTO="end_mpath"
>  ACTION!="add|change", GOTO="end_mpath"
> -KERNEL!="sd*|dasd*", GOTO="end_mpath"
> +KERNEL!="sd*|dasd*|nvme*", GOTO="end_mpath"
>  
>  IMPORT{cmdline}="nompath"
>  ENV{nompath}=="?*", GOTO="end_mpath"
> -- 
> 2.15.1