[dm-devel] [PATCH] multipath-tools: Makefile: Respect standard toolchain related envvars

[Martin Wilck]

On Fri, 2018-01-12 at 00:26 +0100, Thomas Deutschmann wrote:
> On 2018-01-11 23:24, Martin Wilck wrote:
> > 
> > Currently, setting OPTFLAGS is the preferred way to customize
> > multipath-tools build.
> 
> And this works for you with the current multipath-tools package?
> Sorry,
> maybe I am missing something but from my understanding the Makefile
> is
> currently setting OPTFLAGS via
> 
>   OPTFLAGS = -O2 -g ....

Yes it works. Your can do e.g.

make OPTFLAGS="-g -O3 -fsanitize=address"

> So any OPTFLAGS value you are currently passing should be ignored at
> the
> moment. That's why Bart and I independently from each other created
> this
> patch.

OPTFLAGS from the environment is ignored, but OPTFLAGS from the command
line is honored.

https://www.gnu.org/software/make/manual/make.html#Environment
https://www.gnu.org/software/make/manual/make.html#Overriding

Regards,
Martin


-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)