[dm-devel] [PATCH] multipath-tools: Makefile: Respect standard toolchain related envvars

Martin Wilck mwilck at suse.com
Fri Jan 12 22:27:43 UTC 2018


On Fri, 2018-01-12 at 16:46 +0100, Thomas Deutschmann wrote:
> 
> Regarding Bart's patch: Still not sure how important things like
> 
>   -D_FORTIFY_SOURCE=2 $(STACKPROT) --param=ssp-buffer-size=4
> 
> are.

Most of this came came from Red Hat:

commit 1fce66911f4c15e3a9c09948f4c146d859bc1834
Author: Benjamin Marzinski <bmarzins at redhat.com>
Date:   Thu May 24 23:57:42 2012 -0500

    multipath: Build with standard rpm cflags
    
    This patch makes multipath build with the standard redhat rpm
cflags, which
    can help catch some code errors.
    

I haven't questioned these so far. I don't think they have negative
impact, and might help catching errors.

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)




More information about the dm-devel mailing list