[dm-devel] [PATCH 10/14] libmultipath: hwtable: multibus for NetApp NVMe-FC

[Xose Vazquez Perez]

On 01/12/2018 11:07 PM, Martin Wilck wrote:

> Use multibus policy for NetApp NVMe-FC namespace controllers.
> 
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  libmultipath/hwtable.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 40c4724fcd1b..bae280c835e6 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1142,6 +1142,19 @@ static struct hwentry default_hw[] = {
>  		.checker_name  = NONE,
>  		.retain_hwhandler = RETAIN_HWHANDLER_OFF,
>  	},
> +	/*
> +	 * NetApp NVMe-FC namespace devices: MULTIBUS preferred
> +	 *
> +	 * The table is searched backwards, so place this after generic NVMe

Too tricky.

> +	 */
> +	{
> +		.vendor	       = "NVME",
> +		.product       = "(NetApp |)ONTAP Controller)",
                                          ^^ Is this correct?

> +		.uid_attribute = "ID_WWN",
> +		.checker_name  = NONE,
> +		.pgpolicy      = MULTIBUS,
> +		.retain_hwhandler = RETAIN_HWHANDLER_OFF,
> +	},

Place it inside NetApp vendor entry, and remove:
        /*
         * Generic NVMe devices
         */
        {
                .vendor        = "NVME",
                .product       = ".*",
                .uid_attribute = "ID_WWN",
                .checker_name  = NONE,
                .retain_hwhandler = RETAIN_HWHANDLER_OFF,
        },


Thanks.