[dm-devel] [PATCH V3] multipathd: release uxsocket and resource when cancel thread

Martin Wilck mwilck at suse.com
Tue Jan 16 13:19:20 UTC 2018


On Tue, 2018-01-16 at 11:48 +0000, Wuchongyun wrote:
> Hi Martin,
> Sorry to forget that, actually I found that dead_client() will not be
> interrupt by thread cancle, because after all dead_client() calling
> point be done then handle_signals() have chance to be called by
> uxsock_listen() which will call exit_daemon() and send 
> cancel threads signal to all child process include uxlsnr.

Fair enough.

> But your comments is good can make code more safer. Below is the new
> patch, please have a look, thanks.

I think it's really safer whis way, should anyone see the need to
cancel the listener thread from another point in the code.

The patch is looks good now.

Reviewed-by: Martin Wilck <mwilck at suse.com>

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)




More information about the dm-devel mailing list