[dm-devel] [PATCH 1/2] mpathpersist: add all_tg_pt option

[Martin Wilck]

On Wed, 2018-06-06 at 16:56 -0500, Benjamin Marzinski wrote:
> On Wed, Jun 06, 2018 at 10:25:36PM +0200, Martin Wilck wrote:
> > 
> > The patch looks good to me, but doesn't this mean that mpathpersist
> > would now also support persistent reservations with the ALL_TG_PT
> > bit
> > set (IIUC, the VNX basically acts as if that bit was always set)? 
> > 
> > If yes, I think the warning in mpath_prout_reg() about this flag
> > could
> > be dropped, and mpathpersist could be extended to support the -Y/
> > --param-alltgpt option, no?
> 
> I'm a little fuzzy on the --param-alltgpt option. The initial
> mpathpersist sumbission didn't include support for it, on the grounds
> that supporting it would cause mpathpersist to do a lot of extra
> work.
> What I did cuts down on the amout of work that mpathpersist has to
> do.
> If I could clear that up, I'd happily add the option to mpathpersist.
> 

Are you saying you intend to do so? Again, from a user point of view,
without much knowledge about what's going on behind the scenes, seeing
an all_tg_pt option in multipath.conf would make me think that I could 
simply set that option and thus have multipath-tools issue PROUT
commands with the ALL_TG_PT bit set, which isn't true at this point in
time.

Best
Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)