[dm-devel] dm cache: require io_mode cache feature selection to be mutually exclusive

Mike Snitzer snitzer at redhat.com
Wed Jun 27 15:27:11 UTC 2018


On Thu, Jun 21 2018 at  5:35pm -0400,
John Pittman <jpittman at redhat.com> wrote:

> Due to commit 629d0a8a1a10 ("dm cache metadata: add "metadata2" feature"),
> when creating a dm cache device, more than one io_mode can be selected.
> As the io_mode selections are incompatible with one another, we should 
> force them to be selected exclusively.  Add simple ctr to check for 
> more than one io_mode selection.

I'm missing why you're associating your fix with commit 629d0a8a1a10.

Can you explain what you did to hit a problem that this patch is fixing?
Did you list conflicting modes on the ctr and the last one in the table
line won?

Thanks,
Mike




More information about the dm-devel mailing list