[dm-devel] [PATCH v2 09/23] multipath-tools: Makefile.inc: use -Werror=cast-qual
Hannes Reinecke
hare at suse.de
Tue Mar 6 07:08:36 UTC 2018
On 03/06/2018 12:14 AM, Martin Wilck wrote:
> Casting "const" away is often an indicator for wrong code.
> Add a compiler flag to warn about such possible breakage.
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
> Makefile.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index eb99c36010c1..a5b9d4e3fa74 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -87,6 +87,7 @@ STACKPROT := $(call TEST_CC_OPTION,-fstack-protector-strong,-fstack-protector)
> OPTFLAGS = -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int \
> -Werror=implicit-function-declaration -Werror=format-security \
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered \
> + -Werror=cast-qual -Werror=discarded-qualifiers \
> -Wp,-D_FORTIFY_SOURCE=2 $(STACKPROT) \
> --param=ssp-buffer-size=4
>
>
Reviewed-by: Hannes Reinecke <hare at suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
More information about the dm-devel
mailing list