[dm-devel] [PATCH v2 2/2] multipathd: start marginal path checker thread lazily

[Hannes Reinecke]

On 03/06/2018 10:18 PM, Martin Wilck wrote:
> I noticed that the io_error checker thread accounts for most of the
> activity of multipathd even if the marginal path checking paramters
> are not set (which is still the default in most installations I assume).
> 
> Therefore, start the io_error checker thread only if there's at least
> one map with marginal error path checking configured. Also, make sure
> the thread is really up when start_io_err_stat_thread() returns.
> 
> This requires adding a "vecs" argument to setup_map, because vecs
> needs to be passed to the io_error checking code.
> 
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  libmultipath/configure.c   | 14 +++++++++---
>  libmultipath/configure.h   |  3 ++-
>  libmultipath/io_err_stat.c | 55 ++++++++++++++++++++++++++++++++++++++++++----
>  libmultipath/structs_vec.c |  3 ++-
>  multipathd/cli_handlers.c  |  2 +-
>  multipathd/main.c          |  8 ++-----
>  6 files changed, 69 insertions(+), 16 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)