[dm-devel] [PATCH v2 0/5] Fixes for config file parsing

Benjamin Marzinski bmarzins at redhat.com
Wed Mar 14 17:41:07 UTC 2018


On Thu, Mar 08, 2018 at 12:26:15AM +0100, Martin Wilck wrote:
> This series was motivated by the real-world problem that a user couldn't
> figure out how to write a blacklist entry for a device called '1.8" SSD'.
> Fixing this for good turned out to be a little tricky, therefore I also
> added a test suite.
> 
> Changes since v1:
>  - fixed a problem with parsing the command strings from cli handlers.
> 

Reviewed-by: Benjmain Marzinski <bmarzins at redhat.com>

for the set.

> Martin Wilck (5):
>   tests: add unit tests for config file parser
>   libmultipath: config parser: don't strip whitepace between quotes
>   libmultipath: config parser: Allow '"' in strings
>   libmultipath: config parser: fix corner case for double quotes
>   multipath.conf(5): improve syntax documentation
> 
>  libmultipath/parser.c      |  60 ++++--
>  libmultipath/parser.h      |   1 +
>  multipath/multipath.conf.5 |  17 ++
>  multipathd/cli.c           |   2 +-
>  tests/Makefile             |   2 +-
>  tests/globals.c            |   1 +
>  tests/parser.c             | 474 +++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 540 insertions(+), 17 deletions(-)
>  create mode 100644 tests/parser.c
> 
> -- 
> 2.16.1




More information about the dm-devel mailing list