[dm-devel] [PATCH 0/2] Fix recently introduced inconsistencies

Bart Van Assche bart.vanassche at wdc.com
Mon Mar 19 16:23:49 UTC 2018


Hello Christophe,

Analysis of recently introduced inconsistencies learned me the following:
- Not all .c files in the multipath-tools include the corresponding header
  files so the compiler cannot verify consistency of declarations and
  definitions for all declarations.
- A recent change of call-by-reference into call-by-value was incomplete.

This patch series addresses both issues. Please consider these patches for
the official multipath-tools repository.

Thanks,

Bart.

Bart Van Assche (2):
  Allow the compiler to verify consistency of declarations and
    definitions
  libmultipath: Fix recently introduced inconsistencies

 libmultipath/callout.c    |  1 +
 libmultipath/config.c     |  4 ++--
 libmultipath/debug.c      |  1 +
 libmultipath/defaults.c   |  1 +
 libmultipath/dict.c       |  1 +
 libmultipath/dict.h       | 14 +++++++-------
 libmultipath/dmparser.c   |  1 +
 libmultipath/hwtable.c    |  1 +
 libmultipath/propsel.c    | 45 +++++++++++++++++++++++----------------------
 libmultipath/propsel.h    |  4 ++--
 mpathpersist/main.c       |  1 +
 multipathd/cli_handlers.c |  1 +
 multipathd/uxclnt.c       |  1 +
 13 files changed, 43 insertions(+), 33 deletions(-)

-- 
2.16.2




More information about the dm-devel mailing list