[dm-devel] Revert "dm btree: use GFP_NOFS in dm_btree_del()"
Matthew Wilcox
willy at infradead.org
Mon Mar 19 19:21:35 UTC 2018
Hi Mike, Joe,
Please consider reverting commit 9f9ef0657d53d988dc07b096052b3dd07d6e3c46.
The reasoning is flawed -- just because something is an ioctl does not
mean that you should be using GFP_NOFS. The only reason to use GFP_NOFS
is if the filesystem is holding a lock which means that calling into
the filesystem to free memory would deadlock.
If you have a lockdep splat or some chain of reasoning that shows
that there is a filesystem with, eg, an open transaction or holding
an fs-wide lock, then please add some more information to the comment.
Because the comment is wrong, I assume the entire commit is incorrect.
More information about the dm-devel
mailing list