[dm-devel] [PATCH][next] dm writecache: fix missing goto in error handling code

Mike Snitzer snitzer at redhat.com
Tue May 29 18:09:03 UTC 2018


On Sun, May 27 2018 at  6:25pm -0400,
Colin King <colin.king at canonical.com> wrote:

> From: Colin Ian King <colin.king at canonical.com>
> 
> Currently, the -EFBIG error condition when n_bitmaps_bits is
> too large is falling through to the next statement and the
> error assignment to r is potentially being ignored.  The code
> should be exiting to the error path via label 'bad'. Fix
> this by adding the missing goto statement.
> 
> Detected by CoverityScan, CID#1469377 ("Unused value")
> 
> Fixes: bb15b431d650 ("dm: add writecache target")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Thanks, I've picked this up.




More information about the dm-devel mailing list