[dm-devel] [PATCH v3 22/22] libmultipath: make checker_message thread safe

Martin Wilck mwilck at suse.com
Fri Nov 2 08:50:07 UTC 2018


On Thu, 2018-11-01 at 14:53 -0500,  Benjamin Marzinski  wrote:
> On Tue, Oct 30, 2018 at 10:06:53PM +0100, Martin Wilck wrote:
> > Get rid of the static char buffer in checker_message()
> > introduced in the previous "replace message by msgid" patch.
> 
> What you have is fine, but why not something like this, which doesn't
> need to do any allocating?

The reason (apart from myself being blind) was that checker_message()
prints some extra text around the message. But with only two callers,
that's actually over-complicating matters.

Thanks for pointint this out, I'll re-post.

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)





More information about the dm-devel mailing list