[dm-devel] [PATCH V10 05/19] block: introduce bvec_last_segment()

Christoph Hellwig hch at lst.de
Fri Nov 16 13:34:22 UTC 2018


> +	unsigned last_page = total / PAGE_SIZE;
> +
> +	if (last_page * PAGE_SIZE == total)

Not sure it matters much with modern compilers, but generally
we shit by PAGE_SHIFT instead of multiplying with or dividing
by PAGE_SIZE.




More information about the dm-devel mailing list