[dm-devel] [PATCH V12 09/20] block: use bio_for_each_bvec() to compute multi-page bvec count

Christoph Hellwig hch at lst.de
Mon Nov 26 13:11:20 UTC 2018


Looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>

Nitpick below:

> +{
> +	unsigned len = bv->bv_len;
> +	unsigned total_len = 0;
> +	unsigned new_nsegs = 0, seg_size = 0;
> +
> +	/*
> +	 * Multipage bvec may be too big to hold in one segment,
> +	 * so the current bvec has to be splitted as multiple
> +	 * segments.
> +	 */

Please use up all 80 chars in a line.




More information about the dm-devel mailing list