[dm-devel] [PATCH v3 02/19] libmultipath: fix tur checker double locking

Martin Wilck mwilck at suse.de
Mon Oct 1 20:44:06 UTC 2018


On Mon, 2018-10-01 at 22:09 +0200, Martin Wilck wrote:
> 
> I like the lock removal a lot, but not so much the conversion into a
> string. Why not keep the dev_t? 
> 
> Or maybe even easier, the other way around: why don't we make it a
> char* and simply set checker->dev_t = &pp->dev_t?

OK, that 2nd one won't work because pp may be destroyed before the
checker terminates. Got it. Still I'd prefer keeping a dev_t in the
checker structure rather than a char[32].

Martin





More information about the dm-devel mailing list