[dm-devel] [PATCH 05/11] block: Limit allocation of zone descriptors for report zones
Damien Le Moal
damien.lemoal at wdc.com
Wed Oct 10 01:52:33 UTC 2018
There is no point in allocating more zone descriptors than the number of
zones a block device has for doing a zone report. Avoid doing that in
blkdev_report_zones_ioctl() by limiting the number of zone decriptors
allocated internally to process the user request.
Signed-off-by: Damien Le Moal <damien.lemoal at wdc.com>
---
block/blk-zoned.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 32e377f755d8..f2c8b859fc18 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -334,6 +334,7 @@ int blkdev_report_zones_ioctl(struct block_device *bdev, fmode_t mode,
struct request_queue *q;
struct blk_zone_report rep;
struct blk_zone *zones;
+ unsigned int nr_zones;
int ret;
if (!argp)
@@ -355,8 +356,9 @@ int blkdev_report_zones_ioctl(struct block_device *bdev, fmode_t mode,
if (!rep.nr_zones)
return -EINVAL;
- if (rep.nr_zones > INT_MAX / sizeof(struct blk_zone))
- return -ERANGE;
+ nr_zones = blkdev_nr_zones(bdev);
+ if (rep.nr_zones > nr_zones)
+ rep.nr_zones = nr_zones;
zones = kvmalloc_array(rep.nr_zones, sizeof(struct blk_zone),
GFP_KERNEL | __GFP_ZERO);
--
2.17.1
More information about the dm-devel
mailing list