[dm-devel] [PATCH v4 02/19] libmultipath: fix tur checker double locking

Martin Wilck mwilck at suse.de
Wed Oct 10 07:08:09 UTC 2018


On Tue, 2018-10-09 at 18:02 -0500, Benjamin Marzinski wrote:
> tur_devt() locks ct->lock. However, it is ocassionally called while
> ct->lock is already locked. In reality, there is no reason why we
> need
> to lock all the accesses to ct->devt. The tur checker only needs to
> write to this variable one time, when it first gets the file
> descripter
> that it is checking. This patch sets ct->devt in libcheck_init() when
> it
> is first initializing the checker context. After that, ct->devt is
> only
> ever read.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list