[dm-devel] [PATCH 5/6] mpathpersist: fix registration rollback issue
Martin Wilck
mwilck at suse.com
Wed Oct 10 19:41:15 UTC 2018
On Wed, 2018-10-10 at 20:12 +0200, Martin Wilck wrote:
> > diff --git a/libmpathpersist/mpath_persist.c
> > b/libmpathpersist/mpath_persist.c
> > index 29e7fb4..2ffe56e 100644
> > --- a/libmpathpersist/mpath_persist.c
> > +++ b/libmpathpersist/mpath_persist.c
> > @@ -559,11 +559,10 @@ int mpath_prout_reg(struct multipath *mpp,int
> > rq_servact, int rq_scope,
> > }
> > if (rollback && ((rq_servact == MPATH_PROUT_REG_SA) && sa_key
> > != 0 )){
> > condlog (3, "%s: ERROR: initiating pr out rollback",
> > mpp->wwid);
> > + memcpy(¶mp->key, ¶mp->sa_key, 8);
> > + memset(¶mp->sa_key, 0, 8);
> > for( i=0 ; i < count ; i++){
> > if(thread[i].param.status == MPATH_PR_SUCCESS)
> > {
> > - memcpy(&thread[i].param.paramp->key,
> > &thread[i].param.paramp->sa_key, 8);
> > - memset(&thread[i].param.paramp-
> > >sa_key,
> > 0, 8);
> > - thread[i].param.status =
> > MPATH_PR_SUCCESS;
>
> Why did you delete this last statement, too?
For obvious reasons ... Sorry for the noise.
I added a Reviewed-by: tag.
Best,
Martin
--
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
More information about the dm-devel
mailing list