[dm-devel] [PATCH 2/2] kpartx: fix new memory leak in dm_find_part

[Martin Wilck]

On Thu, 2018-10-11 at 15:43 -0500, Benjamin Marzinski wrote:
> While commit 960bb238 fixed one memory leak, it created another.
> 
> Fixes: 960bb238 ("kpartx: Fix memory leak of uuid found by coverity")
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

Reviewed-by: Martin Wilck <mwilck at suse.com>

> ---
>  kpartx/devmapper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kpartx/devmapper.c b/kpartx/devmapper.c
> index 8db1eb5..3aa4988 100644
> --- a/kpartx/devmapper.c
> +++ b/kpartx/devmapper.c
> @@ -690,6 +690,7 @@ int dm_find_part(const char *parent, const char
> *delim, int part,
>  
>  	r = dm_rename(tmp, name);
>  	if (r == 1) {
> +		free(tmp);
>  		*part_uuid = uuid;
>  		return 1;
>  	}

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)