[dm-devel] [PATCH 0/4] multipath-tools: prio handling for offline paths

Martin Wilck mwilck at suse.com
Thu Apr 11 10:49:19 UTC 2019


A recent bug report revealed that the handling of path priorities is
inconsistent in multipathd when paths fail. In the current code, depending
on timing, the prio of a faild path may be reset to 0, reset to -1
(PRIO_UNDEF), or not reset at all. The inconsistency is most obvious
with "group_by_prio", as it results in strange artefacts how failed
paths are regrouped, and how path groups are sorted.

This series tries to address these issues.

The general mind set that I applied is that, in case of doubt, it's
best to retain the priority that was retrieved while the path was
last accessible.

Martin Wilck (4):
  libmultipath: group_by_prio: fix signedness bug
  Revert "Set priority to '0' for PATH_BLOCKED or PATH_DOWN"
  libmultipath: ana prioritizer: decrease log level
  libmultipath: get_prio(): don't reset prio for inaccessible paths

 libmultipath/discovery.c        | 16 +++++++++++-----
 libmultipath/pgpolicies.c       |  2 +-
 libmultipath/prioritizers/ana.c |  2 +-
 3 files changed, 13 insertions(+), 7 deletions(-)

-- 
2.21.0




More information about the dm-devel mailing list