[dm-devel] [PATCH v2] dm mpath: fix missing call of path selector type->end_io

[Martin Wilck]

On Thu, 2019-04-25 at 15:45 -0400, Mike Snitzer wrote:
> On Thu, Apr 25 2019 at  5:25am -0400,
> yuyufen <yuyufen at huawei.com> wrote:
> 
> > > "CANCAL" looks strange - did you mean "CANCEL"?
> > 
> > This is a spelling error.
> > 
> > > Anyway, what do you need this new enum for? Couldn't you just
> > > pass the
> > > disposition (i.e. DM_MAPIO_REQUEUE), and use a different value
> > > (e.g.
> > > DM_ENDIO_DONE) at those call sites where end_io shouldn't be
> > > called?
> > > 
> > > Regards,
> > > Martin
> > > 
> > > 
> > > .
> > > 
> > 
> > Thanks for your suggestion. Passing DM_MAPIO_REQUEUE is a good
> > idea.
> > It indicates that request will be requeued and we need to call
> > ->end_io.
> > 
> > However, I am not sure if it is suitable for use DM_ENDIO_DONE.
> > It is strange that we use DM_ENDIO_DONE in
> > dm_requeue_original_request(),
> > which is called in the case of DM_ENDIO_REQUEUE in dm_done().
> 
> I've staged the following, it doesn't get bogged down with passing
> flags
> (and overloading their use with unnatural new meanings).  Please let
> me
> know if you see any issues:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.2&id=5de719e3d01b4abe0de0d7b857148a880ff2a90b

Nice and simple. Looks good to me.

Reviewed-by: Martin Wilck <mwilck at suse.com>