[dm-devel] [PATCH 01/10] dm-integrity: dont check null pointer before kvfree and vfree

Mikulas Patocka mpatocka at redhat.com
Mon Apr 29 12:57:17 UTC 2019


The functions kfree, vfree and kvfree do nothing if we pass a NULL pointer
to them. So we don't need to test the pointer for NULL.

Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>

---
 drivers/md/dm-integrity.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Index: linux-2.6/drivers/md/dm-integrity.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-integrity.c	2019-04-05 20:29:19.000000000 +0200
+++ linux-2.6/drivers/md/dm-integrity.c	2019-04-05 20:29:19.000000000 +0200
@@ -3548,10 +3548,8 @@ static void dm_integrity_dtr(struct dm_t
 		destroy_workqueue(ic->writer_wq);
 	if (ic->recalc_wq)
 		destroy_workqueue(ic->recalc_wq);
-	if (ic->recalc_buffer)
-		vfree(ic->recalc_buffer);
-	if (ic->recalc_tags)
-		kvfree(ic->recalc_tags);
+	vfree(ic->recalc_buffer);
+	kvfree(ic->recalc_tags);
 	if (ic->bufio)
 		dm_bufio_client_destroy(ic->bufio);
 	mempool_exit(&ic->journal_io_mempool);




More information about the dm-devel mailing list