[dm-devel] [PATCH] multipath-tools: reorder NVDISK devices

[Benjamin Marzinski]

On Thu, Aug 01, 2019 at 07:21:38PM +0200, Xose Vazquez Perez wrote:
> Otherwise "3303[ ]+NVDISK" is never reached, because "NVDISK" regex takes
> priority over it.

Huh? I don't understand why this is necessary. First off, with Martin's
hwentry code, all matching hardware entries are used, not just the
latest. But second, and more importantly, the AIX NVDISK entry won't
ever match the same disks as the IBM 3303[ ]+NVDISK, since they have
different vendors.  Right?

-Ben

> 
> Cc: Brian King <brking at linux.vnet.ibm.com>
> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> Cc: DM-DEVEL ML <dm-devel at redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
> ---
>  libmultipath/hwtable.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index a06872e..8209554 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -696,12 +696,6 @@ static struct hwentry default_hw[] = {
>  		.pgpolicy      = MULTIBUS,
>  		.no_path_retry = (300 / DEFAULT_CHECKINT),
>  	},
> -	{
> -		/* 3303 NVDISK */
> -		.vendor        = "IBM",
> -		.product       = "3303[ ]+NVDISK",
> -		.no_path_retry = (300 / DEFAULT_CHECKINT),
> -	},
>  	{
>  		/* AIX NVDISK */
>  		.vendor        = "AIX",
> @@ -712,6 +706,12 @@ static struct hwentry default_hw[] = {
>  		.no_path_retry = (300 / DEFAULT_CHECKINT),
>  		.prio_name     = PRIO_ALUA,
>  	},
> +	{
> +		/* 3303 NVDISK */
> +		.vendor        = "IBM",
> +		.product       = "3303[ ]+NVDISK",
> +		.no_path_retry = (300 / DEFAULT_CHECKINT),
> +	},
>          /*
>           * Lenovo
>           */
> -- 
> 2.21.0
> 
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel