[dm-devel] [PATCH 04/16] libmultipath: add wrapper function around pgpolicyfn

Benjamin Marzinski bmarzins at redhat.com
Fri Aug 16 21:02:34 UTC 2019


On Wed, Aug 14, 2019 at 09:39:27PM +0000, Martin Wilck wrote:
> On Fri, 2019-08-02 at 11:33 -0500, Benjamin Marzinski wrote:
> > group_paths() is a wrapper around the pgpolicy functions, that pulls
> > out
> > the common code from the beginning and the end. However since
> > one_group() didn't free the mp->paths vector, it has to set it to
> > NULL,
> > to avoid having the wrapper code do that. Also, the pathgroups in
> > group_by_prio are now needlessly sorted afterwards.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> 
> Reviewed-by: Martin Wilck <mwilck at suse.com>
> 
> (Suggestion: squash this with 07/16, and possibly also 05/16 and
> 06/16).
> 

Sure.

-Ben




More information about the dm-devel mailing list