[dm-devel] [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone
Wols Lists
antlists at youngman.org.uk
Fri Aug 30 10:47:24 UTC 2019
On 23/08/19 18:51, Song Liu wrote:
> I guess md_is_broken() should return bool? Otherwise, looks good to me.
Just an outsider's observation - if the function is actually checking
whether a member is missing maybe it should read
broken = md_member_is_missing();
That way the function says what it does, and the assignment says what
you're doing with it.
Cheers,
Wol
More information about the dm-devel
mailing list