[dm-devel] Regression in 5.0-rc4 device-mapper - integrity data invalid

[Milan Broz]

Hi Mike,

since 5.0-rc4 we are not able to use LUKS2 devices with 4k sector size.

For example,
# cryptsetup luksFormat --type luks2 -c aes-xts-plain64 --integrity hmac-sha256 /dev/sdc --sector-size 4096

fails with these syslog errors:
  device-mapper: crypt: Integrity AEAD, tag size 32, IV size 0.
  device-mapper: integrity: Invalid integrity data size 32768, expected 4096
  device-mapper: integrity: Invalid integrity data size 32768, expected 4096

(with 512-byte sectors it seems to work ok)

Bisect shows this commit in rc4 is the problematic one (reverting fixes the problem):

commit 57c36519e4b949f89381053f7283f5d605595b42
Author: Mike Snitzer <snitzer at redhat.com>
Date:   Wed Jan 16 18:53:26 2019 -0500

    dm: fix clone_bio() to trigger blk_recount_segments()
    
    DM's clone_bio() now benefits from using bio_trim() by fixing the fact
    that clone_bio() wasn't clearing BIO_SEG_VALID like bio_trim() does;
    which triggers blk_recount_segments() via bio_phys_segments().
    
    Reviewed-by: Ming Lei <ming.lei at redhat.com>
    Signed-off-by: Mike Snitzer <snitzer at redhat.com>

Could you please check what is missing in the patch?

Milan