[dm-devel] [PATCH] dm: don't overallocate the tags space

Bart Van Assche bvanassche at acm.org
Fri Feb 8 15:58:12 UTC 2019


On Fri, 2019-02-08 at 10:52 -0500, Mikulas Patocka wrote:
> bio_sectors returns the value in the units of 512-byte sectors (no matter
> what's the real sector size of the device). dm-crypt multiplies
> bio_sectors by on_disk_tag_size to calculate the space allocated for
> integrity tags. If dm-crypt is running with sector size larger than 512,
> it allocates more data than what's needed.
> 
> Device mapper trimmed this extra space when passing the bio to
> dm-integrity, so this bug didn't result in any visible misbehavior. This
> bug showed up when device mapper stopped trimming the bio.
> 
> Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>
> Reported-by: Milan Broz <mbroz at redhat.com>

Hi Mikulas,

Is this a fix for commit fa8db4948f52 ("dm: don't use bio_trim() afterall")?
If so, please consider adding a "Fixes:" tag.

Thanks,

Bart.




More information about the dm-devel mailing list