[dm-devel] [PATCH] multipathd: avoid crash in cli_list_path

Martin Wilck mwilck at suse.com
Tue Jan 8 23:25:43 UTC 2019


multipathd can be crashed by passing an invalid path name
to the "show path" command. Fix it.
---
 multipathd/cli_handlers.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c
index 6304ed3a..fabf4440 100644
--- a/multipathd/cli_handlers.c
+++ b/multipathd/cli_handlers.c
@@ -346,6 +346,8 @@ cli_list_path (void * v, char ** reply, int * len, void * data)
 	condlog(3, "%s: list path (operator)", param);
 
 	pp = find_path_by_dev(vecs->pathvec, param);
+	if (!pp)
+		return 1;
 
 	return show_path(reply, len, vecs, pp, "%o");
 }
-- 
2.19.2




More information about the dm-devel mailing list